Goodwill is valued on occasions like change in profit sharing ratio (B), amalgamation of partnership firm (C), and admission of a partner (D). It is not valued at incorporation (no past record) or on dissolution/closure (business is ending). Hence B, C and D.